Update Emby docs #2274
Merged
Update Emby docs #2274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Landrash
reviewed
Mar 17, 2017
| @@ -32,3 +32,4 @@ Configuration variables: | |||
| - **api_key** (*Required*): The api-key you would like home-assistant to use to authenticate. | |||
| - **ssl** (*Optional*): True if you want to connect with https. Be sure to set the port also. | |||
| - **port** (*Optional*): The port number. Defaults to 8096. | |||
| - **auto_hide** (*Optional*): True if you want to automatically hide devices in the "off" state from the UI. | |||
There was a problem hiding this comment.
Default state i missing. Also avoid the uses of abbreviations if not needed.
My suggestion for a rewrite of this sentence would be
+- **auto_hide** (*Optional*): True if you want to automatically hide devices in the "off" state from the Home Assistant Interface. Defaults to False
Landrash
previously requested changes
Mar 17, 2017
| - **api_key** (*Required*): The api-key you would like home-assistant to use to authenticate. | ||
| - **ssl** (*Optional*): True if you want to connect with https. Default is False. | ||
| - **ssl** (*Optional*): True if you want to connect with https/wss. Your SSL certificate must be valid. Default is False. |
|
With the latest pr this component now utilizes websockets (in addition to standard http) which connect with either a ws:// prefix for non secure connections or wss:// prefix for SSL connections. I can remove it if you think it makes things confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update docs for emby media_player component.
Pull request in home-assistant (if applicable): home-assistant/core#6664