Skip to content

Doc for nadtcp media player component #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 9, 2017
Merged

Doc for nadtcp media player component #2368

merged 10 commits into from
Jun 9, 2017

Conversation

mwsluis
Copy link

@mwsluis mwsluis commented Apr 1, 2017

Pull request in home-assistant (if applicable): home-assistant/core#7955

Initial commit.
min_volume: -60
max_volume: -20
volume_step: 5
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to keep all configuration samples minimal. Thus, no optional requirement in the default sample. This helps user to get started quickly by copy-&-paste the sample without worrying about optional parameters which they most likely not need. If required, insert a full configuration sample later that covers special setups or alike.

@fabaff fabaff added the new-integration This PR adds documentation for a new Home Assistant integration label Apr 3, 2017
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged after parent PR is merged.

ha_release will need to be updated to reflect the correct version it's merged into.

@mwsluis mwsluis changed the title Doc for nad7050 medial player component Doc for nadtcp medial player component Jun 8, 2017
@mwsluis mwsluis changed the title Doc for nadtcp medial player component Doc for nadtcp media player component Jun 8, 2017
@emlove emlove merged commit 2d686b7 into home-assistant:next Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants