Skip to content

Document core language and country setting #25047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2022
Merged

Document core language and country setting #25047

merged 3 commits into from
Nov 25, 2022

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Nov 25, 2022 •
edited
Loading

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Nov 25, 2022
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@emontnemery emontnemery mentioned this pull request Nov 25, 2022
Merged
19 tasks
frenck
frenck reviewed Nov 25, 2022
View reviewed changes
@home-assistant home-assistant bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Nov 25, 2022
@home-assistant home-assistant bot added the has-parent This PR has a parent PR in another repo label Nov 25, 2022
emontnemery and others added 2 commits November 25, 2022 12:58
@emontnemery @frenck
Apply suggestions from code review
d134439 
Co-authored-by: Franck Nijhof <git@frenck.dev>
@emontnemery
Update basic.markdown
7ba18fa
frenck
frenck approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @emontnemery 👍

@frenck frenck merged commit fd79950 into next Nov 25, 2022
@frenck frenck deleted the emontnemery-patch-1 branch November 25, 2022 12:33
@home-assistant home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Nov 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emontnemery @frenck