Skip to content

Add documentation for the Enviro pHAT sensor #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2017

Conversation

imrehg
Copy link
Contributor

@imrehg imrehg commented May 3, 2017

Description:

Add support for the Enviro pHAT for Raspberry Pi (sensor.envirophat), see hardware
info at https://shop.pimoroni.com/products/enviro-phat

Pull request in home-assistant: home-assistant/core#7427

@Landrash Landrash added the new-integration This PR adds documentation for a new Home Assistant integration label May 4, 2017
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor clean-up and this is good to go.

footer: true
logo: raspberry-pi.png
ha_category: Sensor
ha_iot_class: "Local Push"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ha_version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was merged but not released yet, what should happen, wait for the actual release, or how to know what the ha_version value should be?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.44 is up next

ha_iot_class: "Local Push"
---

The `envirophat` sensor platform allows you to display information collected by an [Enviro pHATT](https://shop.pimoroni.com/products/enviro-phat) add-on board for the Raspberry Pi. The board featues a wide range of sensors, such as:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double TT in pHATT


Configuration variables:

- **display_options** (*Optional*) array: List of readings to monitor. Defaults is monitoring all of them:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Defaults" should be "Defaults" I believe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean "Default" (without the plural, right?)

- **voltage_3**: voltage reading on Analog In 3 in units of V
- **use_led** (*Optional*) True / False boolean; Default value is False, declaring that the onboard LEDs are *not* used for the color measurements thus these readings are based on the ambient light. If the value is set to True, the onboard LEDs will blink whenever a reading is taken.

**Notes**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put ## in front of your note to make it a Title.

```


### Directions for installing on Raspberry Pi All-In-One installer and HASSbian:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the packages not installed by default by the component? If they are this section should really not be needed.

pip3 install envirophat
```

#### Enabling the required `i2c-1` device
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is not part of the above comment.


### Give the values friendly names & icons

Add something like the following to your [`customize` section](/docs/configuration/customizing-devices/):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend removing the ` around customize since the formatting is overwritten by the link color.

@Landrash
Copy link
Contributor

Landrash commented May 4, 2017

Changes looks really good! 🍰

@imrehg
Copy link
Contributor Author

imrehg commented May 4, 2017 via email

@imrehg
Copy link
Contributor Author

imrehg commented May 4, 2017

Added updates as mentioned + caught some more.

@balloob balloob added this to the 0.44 milestone May 5, 2017
@balloob balloob dismissed Landrash’s stale review May 5, 2017 04:54

Concerns addressed

@balloob balloob merged commit fa9718c into home-assistant:next May 5, 2017
balloob pushed a commit that referenced this pull request May 5, 2017
* Add documentation for the Enviro pHAT sensor

* sensor.envirophat: incorporating feedback

* sensor.envirophat: update metadata
@balloob
Copy link
Member

balloob commented May 5, 2017

Cherry-picked for 0.44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants