Skip to content

Addition of doc for PR in iframe card #25907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 1, 2023
Merged

Addition of doc for PR in iframe card #25907

merged 4 commits into from
Feb 1, 2023

Conversation

cnico
Copy link
Contributor

@cnico cnico commented Jan 23, 2023

Proposed change

Addition of for home-assistant/frontend#15063

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • [] Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jan 23, 2023
frenck
frenck reviewed Jan 24, 2023
View reviewed changes
frenck
frenck reviewed Jan 24, 2023
View reviewed changes
@alanmilinovic
Copy link

Looks like this change is still stuck?

@frenck
Copy link
Member

frenck commented Feb 1, 2023

@alanmilinovic Not stuck, just the merge upstream hasn't been marked/noticed.
Will address this to get it into the right place. Thanks for the notification 👍

../Frenck

@frenck frenck added this to the 2023.2.0 milestone Feb 1, 2023
@frenck frenck added the parent-merged The parent PR has been merged already label Feb 1, 2023
@alanmilinovic
Copy link

@alanmilinovic Not stuck, just the merge upstream hasn't been marked/noticed. Will address this to get it into the right place. Thanks for the notification 👍

../Frenck

Sounds good, tnx for all the hard work.

frenck
frenck approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @cnico 👍

@frenck frenck merged commit 5032b66 into home-assistant:next Feb 1, 2023
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Feb 1, 2023
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Feb 1, 2023
frenck added a commit that referenced this pull request Feb 1, 2023
@cnico @frenck
Addition of doc for PR in iframe card (#25907)
9e0d6e9 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
2023.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cnico @alanmilinovic @frenck