Skip to content

Documentation update for sensor.hp_ilo #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2017
Merged

Documentation update for sensor.hp_ilo #2608

merged 1 commit into from
May 31, 2017

Conversation

bjw-s
Copy link
Contributor

@bjw-s bjw-s commented May 10, 2017

Description:
Documentation update for the HP ILO sensor component. Some major redesign was done on this component.

Pull request in home-assistant (if applicable): home-assistant/core#7534

@mention-bot
Copy link

@Juggels, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff to be a potential reviewer.

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged after date it restored and parent PR is merged.

@@ -2,7 +2,7 @@
layout: page
title: "HP ILO"
description: "How to integrate HP ILO (Integrated Lights-Out) sensors within Home Assistant."
date: 2016-08-15 19:00
date: 2017-05-10 19:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the date as it was since the creation date of this document hasn't changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allright, will change that. Thought that it was the date of last modification.

@Landrash Landrash added Enhancement new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels May 11, 2017
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged after parent PR is merged.

Revert document date

Align docs with requested PR changes

Align docs with requested PR changes

Align docs with requested PR changes
@bjw-s
Copy link
Contributor Author

bjw-s commented May 30, 2017

parent PR has been merged

@Landrash Landrash merged commit df5bb87 into home-assistant:next May 31, 2017
@Landrash
Copy link
Contributor

Thank you 🎂

@bjw-s bjw-s deleted the hp_ilo branch June 6, 2017 05:52
@bjw-s
Copy link
Contributor Author

bjw-s commented Jun 6, 2017

Hi @Landrash, is there something wrong in the rendering of this page? The values for 'value_template' in the example section don't seem to be generated in the end result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants