Skip to content

Documentation for Buienradar sensor- and weather-component #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 5, 2017
Merged

Documentation for Buienradar sensor- and weather-component #2638

merged 6 commits into from
Jun 5, 2017

Conversation

mjj4791
Copy link
Contributor

@mjj4791 mjj4791 commented May 15, 2017

Description:
Added documentation for buienradar weather-component and buienradar sensor-component.

Pull request in home-assistant (if applicable): home-assistant/core/pull/7592

@fabaff fabaff added the new-integration This PR adds documentation for a new Home Assistant integration label May 16, 2017
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback but looks good in general 😸

@@ -0,0 +1,86 @@
---
layout: page
title: "buienradar"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital B in the title.


The `buienradar` platform uses [buienradar.nl](http://buienradar.nl/) as an source for current meteorological data for your location. The
weather forecast is delivered by Buienradar, who provides a webservice that provides detailed weather information for users in The Netherlands.
The relevant weatherstation used will be automatically selected based on the location specified in the HA config (or in the buienradar weather/sensor component).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid the use of HA and instead write out the full name of Home Assistant. Similarly config should be configuration.

weather forecast is delivered by Buienradar, who provides a webservice that provides detailed weather information for users in The Netherlands.
The relevant weatherstation used will be automatically selected based on the location specified in the HA config (or in the buienradar weather/sensor component).

To add the buienradar sensor to your installation, add the following to your `configuration.yaml` file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest rephrasing this to

To integrate an buienradar with Home Assistant, add the following section to your configuration.yaml file:

- **precipitation**: the amount of precipitation/rain in mm/h.
- **irradiance**: Sun intensity in Watt per square meter (W/m2).

A full configuration example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest rewriting this as

Full configuration example where location is manually specified.

Also this example could differ from the one above and one could only use a subset of the monitored_conditions.

# Example configuration.yaml entry
weather:
- platform: buienradar
name: buienradar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the name variable since it's not a required variable. It's better to limit the example configuration to only required variables since it's often copy and pasted.

Configuration variables:
- **platform** (*Required*): buienradar
- **name** (*Optional*): A name for the weather platform.
- **latitude** (*Optional*): latitude to use for selection of data source location. Longitude & latitude will be taken from HA configuration, but can be overridden/changed in this component to select a different location for buienradar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HA should be replaced with Home Assistant

- **platform** (*Required*): buienradar
- **name** (*Optional*): A name for the weather platform.
- **latitude** (*Optional*): latitude to use for selection of data source location. Longitude & latitude will be taken from HA configuration, but can be overridden/changed in this component to select a different location for buienradar.
- **longitude** (*Optional*): longitude to use for selection of data source location. Longitude & latitude will be taken from HA configuration, but can be overridden/changed in this component to select a different location for buienradar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HA should be replaced with Home Assistant

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged when parent PR is merged.

@balloob balloob merged commit 6d4129c into home-assistant:next Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants