Skip to content

Add a Jasco integration page #26416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

Add a Jasco integration page #26416

merged 1 commit into from
Mar 6, 2023

Conversation

b-uwe
Copy link
Contributor

@b-uwe b-uwe commented Mar 1, 2023

Proposed change

Add a Jasco integration page

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • The core change is quite old and the partnership was announced, yet the integration page was forgotten!
  • It's fuckup day for me today, sorry for repeating Add a Jasco integration page #26413 🤦‍♂️🤷

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added current This PR goes into the current branch in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 1, 2023
@home-assistant
Copy link

home-assistant bot commented Mar 1, 2023

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@b-uwe
Copy link
Contributor Author

b-uwe commented Mar 1, 2023

Definitely meant for current branch!

@b-uwe b-uwe removed their assignment Mar 1, 2023
@b-uwe b-uwe requested a review from frenck March 1, 2023 18:27
frenck
frenck approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @b-uwe 👍

../Frenck

@frenck frenck merged commit 6f05a80 into home-assistant:current Mar 6, 2023
@home-assistant home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Mar 6, 2023
sreisi pushed a commit to sreisi/home-assistant.io that referenced this pull request Mar 7, 2023
@b-uwe @sreisi
Add a Jasco integration page (home-assistant#26416)
838f15f
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2023
@b-uwe b-uwe deleted the jasco_integration branch March 31, 2023 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-uwe @frenck