Updated pygments.rb to latest to make it build under ruby 2.4 #2644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this change affect the availability of building on any of the other platforms? |
|
@Landrash Nope I do not think so. I just built it on Ubuntu 16.04 with ruby 2.3.1 Seems to be completely fine. |
|
OK with you @fabaff ? |
|
Just found this problem the hard way.. tried 2.4 then found this when I was going to log the issue. It might be kinder to newbies to merge the change... 😉 |
|
Works on an older version of ruby too. $ ruby -v
ruby 2.3.3p222 (2016-11-21 revision 56859) [x86_64-linux] |
|
We should probably try to update all our gems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
On latest OS X, default ruby is 2.4. Older version of Pygments.rb depends on a version of yajl-ruby that is not buildable on latest ruby 2.4. Updated pygments to latest version. Issue #1887 seems to refer to this issue.