Skip to content

Add clarification for reolink entities #26469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 6, 2023
Merged

Add clarification for reolink entities #26469

merged 7 commits into from
Mar 6, 2023

Conversation

starkillerOG
Copy link
Contributor

Proposed change

Add clarification for reolink entities

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Mar 6, 2023
@starkillerOG starkillerOG mentioned this pull request Mar 6, 2023
Merged
19 tasks
@starkillerOG
Copy link
Contributor Author

@frenck can you merge this?
(It is about the core PRs you merged).

@frenck
Copy link
Member

frenck commented Mar 6, 2023

@starkillerOG Can you please stop mentioning and pulling people into PRs?

https://developers.home-assistant.io/docs/review-process#what-not-to-do

frenck
frenck requested changes Mar 6, 2023
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft March 6, 2023 15:11
@home-assistant
Copy link

home-assistant bot commented Mar 6, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

starkillerOG and others added 5 commits March 6, 2023 16:27
@starkillerOG @frenck
Update source/_integrations/reolink.markdown
a392911 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@starkillerOG @frenck
Update source/_integrations/reolink.markdown
c03fd19 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@starkillerOG @frenck
Update source/_integrations/reolink.markdown
842edcf 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@starkillerOG @frenck
Update source/_integrations/reolink.markdown
776c4cb 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@starkillerOG @frenck
Update source/_integrations/reolink.markdown
d3b0c14 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@starkillerOG starkillerOG marked this pull request as ready for review March 6, 2023 17:27
@home-assistant home-assistant bot requested a review from frenck March 6, 2023 17:28
frenck
frenck approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

../Frenck

@frenck frenck merged commit 69c01f5 into home-assistant:next Mar 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@starkillerOG @frenck