Skip to content

Remove Darksky #26740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2023
Merged

Remove Darksky #26740

merged 5 commits into from
Apr 3, 2023

Conversation

gjohansson-ST
Copy link
Member

Proposed change

Remove Darksky integration as API shuts down March 31st.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Mar 27, 2023
@gjohansson-ST gjohansson-ST marked this pull request as ready for review March 27, 2023 07:42
@gjohansson-ST gjohansson-ST requested a review from fabaff as a code owner March 27, 2023 07:42
@gjohansson-ST gjohansson-ST mentioned this pull request Mar 27, 2023
Merged
20 tasks
frenck
frenck requested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dark_sky.png has been removed in this PR, but that image is used in quite a bunch of places.

I suggest not to remove it.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 27, 2023 07:46
@gjohansson-ST gjohansson-ST marked this pull request as ready for review March 27, 2023 07:51
@home-assistant home-assistant bot requested a review from frenck March 27, 2023 07:51
frenck
frenck approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Mar 27, 2023
@frenck frenck added this to the 2023.4 milestone Apr 3, 2023
@frenck frenck merged commit 5c5bc51 into home-assistant:next Apr 3, 2023
@home-assistant home-assistant bot removed the awaits-parent Awaits the merge of an parent PR label Apr 3, 2023
@gjohansson-ST gjohansson-ST deleted the darksky-removal branch April 3, 2023 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2023
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
2023.4
Development

Successfully merging this pull request may close these issues.
2 participants
@gjohansson-ST @frenck