Skip to content

Add new sensors to airq integration #26761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2023
Merged

Add new sensors to airq integration #26761

merged 3 commits into from
Apr 5, 2023

Conversation

Sibgatulin
Copy link
Contributor

Proposed change

Recently a bunch of new sensors has been added to the device, so the integration is being updated.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: Add new sensors to airq core#90413
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Mar 28, 2023
@Sibgatulin Sibgatulin mentioned this pull request Mar 28, 2023
Merged
20 tasks
frenck
frenck previously approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Mar 28, 2023
emontnemery
emontnemery reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the core PR, new sensors are added in new firmware versions. Should the table include a minimum firmware version for the new sensors?

@frenck frenck added the parent-merged The parent PR has been merged already label Mar 29, 2023
@Sibgatulin
Copy link
Contributor Author

Good point @emontnemery. Frankly, I am not completely sure, as the devices which have these physical sensors already have the necessary firmware version, while for older devices a firmware update will not change anything in the operation of the integration.

Except for a few of the new virtual sensors, namely "Relative Pressure" and "Virus Index", which need to be explicitly activated. This, however, cannot be done by the integration in its present state and the users need to follow instructions from the devices non-public documentation.

Would the following be a suitable addition to this PR or should I open another?

Virtual sensors "Relative Pressure" and "Virus Index" are introduced in firmware v1.80.0 but deactivated by default. Instructions to activate can be found in the [technical documentation](https://docs.air-q.com/).

(The core PR mentions firmware v1.82.0, which introduced for the bulk of the new sensors, but not this two special cases.)

@frenck frenck added this to the 2023.4 milestone Mar 29, 2023
@Sibgatulin
Explain the meaning and the activation process for some of the new se…
b4e0d22 
…nsors

"Virus Index" and "Relative Pressure" need to be activated after the
device receives the firmware update introducing them.
Additionally, clarify the meaning of "Virus Index"
frenck
frenck reviewed Apr 3, 2023
View reviewed changes
@Sibgatulin @frenck
Update source/_integrations/airq.markdown
05c7c5d 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
frenck approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Sibgatulin 👍

../Frenck

@frenck frenck merged commit 0456f07 into home-assistant:next Apr 5, 2023
@home-assistant home-assistant bot removed parent-merged The parent PR has been merged already awaits-parent Awaits the merge of an parent PR labels Apr 5, 2023
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Apr 5, 2023
frenck added a commit that referenced this pull request Apr 5, 2023
@Sibgatulin @frenck
Add new sensors to airq integration (#26761)
7ba8c87 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2023
@Sibgatulin Sibgatulin deleted the air_q-add_new_sensors branch April 6, 2023 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emontnemery emontnemery emontnemery left review comments

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
2023.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Sibgatulin @frenck @emontnemery