Skip to content

HomeSeer partnership announcement blog post #26811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

HomeSeer partnership announcement blog post #26811

wants to merge 2 commits into from

Conversation

b-uwe
Copy link
Contributor

@b-uwe b-uwe commented Mar 31, 2023

Proposed change

Announce the HomeSeer partnership in a blog post

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Mar 31, 2023
@b-uwe b-uwe marked this pull request as ready for review March 31, 2023 11:21
@b-uwe b-uwe force-pushed the homeseer_partnership_post branch from 12aed95 to 0da541c Compare March 31, 2023 11:27
@frenck frenck added the blog This PR adds a blog article to the Home Assistant website label Mar 31, 2023
@frenck frenck marked this pull request as draft March 31, 2023 11:32
@frenck
Copy link
Member

frenck commented Mar 31, 2023

Marking as draft to prevent accidental merge (as it is dated in the future).

frenck
frenck requested changes Mar 31, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, the PR is, however, targeting an incorrect branch.

This PR should target the current branch, as it is just a blog post that is being put out (not directly bound to a HA release).

../Frenck

@b-uwe
Copy link
Contributor Author

b-uwe commented Mar 31, 2023

@frenck I oriented on #26415 which also targeted next. Was that wrong back then as well or did you do some magic at that time that I can't perceive today?

On a different note, the way I get it it's comparably safe to merge beforehand (accidentally or not) because the blog post will not be visible until the date given.

@frenck
Copy link
Member

frenck commented Mar 31, 2023

@frenck I oriented on #26415 which also targeted next.

Yes, but that is related to a change in the code base and is release together (core + docs at the same time). This blog post isn't.

On a different note, the way I get it it's comparably safe to merge beforehand (accidentally or not) because the blog post will not be visible until the date given.

That doesn't work like that, we have a static site generator... meaning everything you see is generated at build time. The post thus, will only show up when built after that date.

@b-uwe
Copy link
Contributor Author

b-uwe commented Mar 31, 2023

I will start over! That's quicker and easier!

@b-uwe b-uwe closed this Mar 31, 2023
@b-uwe b-uwe deleted the homeseer_partnership_post branch March 31, 2023 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck requested changes

Assignees
No one assigned
Labels
blog This PR adds a blog article to the Home Assistant website has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-uwe @frenck