Skip to content

Add matter cover platform #26857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2023
Merged

Add matter cover platform #26857

merged 2 commits into from
Apr 4, 2023

Conversation

hidaris
Copy link
Contributor

@hidaris hidaris commented Apr 4, 2023

Proposed change

add cover to matter platform, update some outdated information.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Apr 4, 2023
@hidaris hidaris mentioned this pull request Apr 4, 2023
Merged
20 tasks
@marcelveldt
Copy link
Member

There are unrelated changes in your PR, please only add the addition of the cover platform

marcelveldt
marcelveldt reviewed Apr 4, 2023
View reviewed changes
marcelveldt
marcelveldt reviewed Apr 4, 2023
View reviewed changes
marcelveldt
marcelveldt reviewed Apr 4, 2023
View reviewed changes
marcelveldt
marcelveldt requested changes Apr 4, 2023
View reviewed changes
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

@home-assistant home-assistant bot marked this pull request as draft April 4, 2023 06:55
@home-assistant
Copy link

home-assistant bot commented Apr 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@klaasnicolaas klaasnicolaas added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Apr 4, 2023
@MartinHjelmare MartinHjelmare changed the title add cover to matter platform, update some outdated information. Add matter cover platform Apr 4, 2023
@hidaris hidaris marked this pull request as ready for review April 4, 2023 09:57
@home-assistant home-assistant bot requested a review from marcelveldt April 4, 2023 09:57
@MartinHjelmare MartinHjelmare added the parent-merged The parent PR has been merged already label Apr 4, 2023
@MartinHjelmare MartinHjelmare merged commit ae4a491 into home-assistant:next Apr 4, 2023
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Apr 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@marcelveldt marcelveldt Awaiting requested review from marcelveldt

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hidaris @marcelveldt @MartinHjelmare @klaasnicolaas