Skip to content

Update UDP ports used by new aioswitcher version #26950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2023
Merged

Update UDP ports used by new aioswitcher version #26950

merged 2 commits into from
Apr 11, 2023

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented Apr 11, 2023

Proposed change

Update UDP ports used by new aioswitcher version 3.3.0

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Apr 11, 2023
@regevbr regevbr changed the title Patch 1 Update UDP ports used by new aioswitcher version Apr 11, 2023
thecode
thecode requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed we should use ,

source/_integrations/switcher_kis.markdown Outdated
@@ -88,5 +88,5 @@ Note: This does not affect the auto off timer.

## Notes

Make sure that Home Assistant host's firewall allows incoming traffic on UDP ports 20002 & 20003 and outgoing connections to Switcher device(s) on TCP ports 9957 & 10000.
Make sure that Home Assistant host's firewall allows incoming traffic on UDP ports 10002 & 20002 & 20003 and outgoing connections to Switcher device(s) on TCP ports 9957 & 10000.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Make sure that Home Assistant host's firewall allows incoming traffic on UDP ports 10002 & 20002 & 20003 and outgoing connections to Switcher device(s) on TCP ports 9957 & 10000.
Make sure that Home Assistant host's firewall allows incoming traffic on UDP ports 10002, 20002 & 20003 and outgoing connections to Switcher device(s) on TCP ports 9957 & 10000.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 11, 2023 14:32
@regevbr regevbr marked this pull request as ready for review April 11, 2023 14:34
@home-assistant home-assistant bot requested a review from thecode April 11, 2023 14:34
@thecode thecode merged commit 8921f18 into home-assistant:next Apr 11, 2023
xeniter pushed a commit to xeniter/home-assistant.io that referenced this pull request Apr 11, 2023
@regevbr @xeniter
Update UDP ports used by new aioswitcher version (home-assistant#26950)
5639755 
* Update UDP ports used by new aioswitcher version

* Update UDP ports used by new aioswitcher version
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thecode thecode thecode approved these changes

@allenporter allenporter Awaiting requested review from allenporter

@teharris1 teharris1 Awaiting requested review from teharris1

@bdraco bdraco Awaiting requested review from bdraco

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regevbr @thecode