Skip to content

Conversation

shmuelzon
Copy link
Contributor

Proposed change

Added support for the h264_v4l2m2m codec to utilize, among others, the Raspberry Pi's hardware h.264 encoder. Unfortunately, the implementation of the Pi's encoder doesn't use the standard h.264 profile names but expects a numerical value:

$ v4l2-ctl --list-ctrls-menu -d 11
h264_profile 0x00990a6b (menu)   : min=0 max=4 default=4 value=4
             0: Baseline
             1: Constrained Baseline
             2: Main
             4: High

To support that, this commit also adds the option to override the
default profile names used when passed to the FFmpeg encoding process.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@shmuelzon shmuelzon requested a review from bdraco as a code owner April 11, 2023 20:04
@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Apr 11, 2023
@shmuelzon shmuelzon force-pushed the add_homekit_rpi_transcoding branch from 2001df4 to 7bf231b Compare April 12, 2023 15:54
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge when parent PR merges

@bdraco bdraco added the parent-merged The parent PR has been merged already label Apr 12, 2023
@frenck frenck merged commit c30ec90 into home-assistant:next Apr 12, 2023
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Apr 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants