Skip to content

Conversation

infamy
Copy link
Contributor

@infamy infamy commented May 23, 2017

Updater improvements to send option component information, home-assistant/core#7720

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Updater improvements to send option component information, home-assistant/core#7720

The data sent back is fairly limitied:
```json
"components": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra [ in example code

"camera",
"camera.uvc",
"config",
"config.core"...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove dot's since their not valid in the example.

"config",
"config.core"...
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documenatatio for configuration variables will need to be added.

@Landrash Landrash added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label May 24, 2017
@andrey-git
Copy link
Contributor

Since this is new and OptIn, how about making the reported data aggregated-public? I.e. publish the count for each component?

@balloob
Copy link
Member

balloob commented Jun 16, 2017

@andrey-git that is a good idea. Looping in @robbiet480 on how we should do that. I guess the easiest for now is to just generate a report every month or something.

@balloob balloob merged commit 934336a into next Jun 16, 2017
@balloob balloob deleted the infamy-patch-1 branch June 16, 2017 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants