Skip to content

Add more info about the /api/history/period route #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2017
Merged

Add more info about the /api/history/period route #2699

merged 1 commit into from
May 25, 2017

Conversation

bokub
Copy link
Contributor

@bokub bokub commented May 23, 2017

Description:

The documentation about the /api/history/period route is too light:

  • we don't know if <timestamp> is the beginning or the end of the period
  • the end_time parameter is in the code but nowhere in the doc
  • we don't know the default period length

I added some precisions

@mention-bot
Copy link

@bokub, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @jackmakesthings to be potential reviewers.

@bokub
Copy link
Contributor Author

bokub commented May 23, 2017

P.S: Rendered preview:


capture

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff
Copy link
Member

fabaff commented May 25, 2017

@bokub, feel free to submit extensions/additions to the existing documentation against the current branch. This way it would be online immediately.

@fabaff fabaff merged commit e24bbff into home-assistant:next May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants