Skip to content

Onboarding: update screenshots #27511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 25, 2023
Merged

Onboarding: update screenshots #27511

merged 4 commits into from
May 25, 2023

Conversation

c0ffeeca7
Copy link
Contributor

Proposed change

Onboarding: update screenshots

  • add step on analytics
  • Reformat procedure to use numbered steps / procedural format

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@c0ffeeca7
Onboarding: update screenshots
8f96fdd 
- add step on analytics
- Reformat procedure to use numbered steps / procedural format
@home-assistant home-assistant bot added the current This PR goes into the current branch label May 25, 2023
c0ffeeca7
c0ffeeca7 commented May 25, 2023
View reviewed changes
Copy link
Contributor Author

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style guide

@c0ffeeca7 c0ffeeca7 marked this pull request as ready for review May 25, 2023 09:09
frenck
frenck requested changes May 25, 2023
View reviewed changes
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 25, 2023 10:08
@c0ffeeca7 @frenck
Apply suggestions from code review
74e5021 
Co-authored-by: Franck Nijhof <git@frenck.dev>
frenck
frenck approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge when it is ready 👍

../Frenck

@c0ffeeca7 c0ffeeca7 marked this pull request as ready for review May 25, 2023 10:24
@home-assistant home-assistant bot requested a review from frenck May 25, 2023 10:24
@c0ffeeca7 c0ffeeca7 merged commit d2fd3bc into current May 25, 2023
@c0ffeeca7 c0ffeeca7 deleted the update-onboarding branch May 25, 2023 10:24
@c0ffeeca7
Copy link
Contributor Author

thank you!

@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck Awaiting requested review from frenck

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c0ffeeca7 @frenck