Skip to content

Add service_url config option to volvooncall #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

palp
Copy link

@palp palp commented Jun 5, 2017

Description:
Doc change for home-assistant/core#7919

Pull request in home-assistant (if applicable): home-assistant/core#7919

@palp palp changed the title Update volvooncall.markdown Add service_url config option to volvooncall Jun 5, 2017
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged when parent PR is merged.

@palp
Copy link
Author

palp commented Jun 7, 2017

I sniffed the app traffic to check for other URLs and found China has a different one as well, so I added an example for that.

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged when parent PR is merged.

@Landrash Landrash merged commit c0dc694 into home-assistant:next Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants