Skip to content

add ripple sensor #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2017
Merged

add ripple sensor #2781

merged 2 commits into from
Jun 7, 2017

Conversation

nkgilley
Copy link
Contributor

@nkgilley nkgilley commented Jun 6, 2017

Description:

Pull request in home-assistant (if applicable): home-assistant/core#7935

@nkgilley nkgilley mentioned this pull request Jun 6, 2017
6 tasks
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one minor comment.

---


The `Ripple` sensor platform displays Ripple wallet balances from [Ripple.com](https://ripple.com).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component names shouldn't be with a capital letter.

ripple instead of Ripple

@Landrash Landrash added the new-integration This PR adds documentation for a new Home Assistant integration label Jun 7, 2017
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 098a6f5 into home-assistant:next Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants