Skip to content

Documentation: Added TP-Link EP25 Smart Plug to supported devices #28164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

Documentation: Added TP-Link EP25 Smart Plug to supported devices #28164

merged 1 commit into from
Jul 10, 2023

Conversation

ReevMich
Copy link
Contributor

@ReevMich ReevMich commented Jul 10, 2023 •
edited
Loading

Added EP25 Smart plug model to list of supported devices.
Just added it to my home assistant instance no problem

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@ReevMich ReevMich requested a review from rytilahti as a code owner July 10, 2023 19:41
@home-assistant home-assistant bot added the current This PR goes into the current branch label Jul 10, 2023
@ReevMich ReevMich changed the title Added EP25 Smart Plug model to supported devices Added EP25 Smart Plug to supported devices in documentation Jul 10, 2023
@ReevMich ReevMich changed the title Added EP25 Smart Plug to supported devices in documentation Added TPLink EP25 Smart Plug to supported devices in documentation Jul 10, 2023
@ReevMich ReevMich changed the title Added TPLink EP25 Smart Plug to supported devices in documentation Documentation: Added TP-Link EP25 Smart Plug to supported devices Jul 10, 2023
rytilahti
rytilahti approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would you mind creating an upstream PR that adds this model and it's test fixture? See https://python-kasa.readthedocs.io/en/latest/#supported-devices and the script mentioned there.

@rytilahti rytilahti merged commit 0238e9d into home-assistant:current Jul 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReevMich @rytilahti