Add network_key configuration #2828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network key can be set here rather than in the (difficult to find) configuration `options.xml`. It takes the same comma separated "0xNN" string syntax as previous.
dale3h
requested changes
Jun 16, 2017
Removed the options.xml information that is on longer required as per comments from @dale3h
|
Looks good! 🎃 |
dale3h
approved these changes
Jun 16, 2017
|
Just a quick question - If I already have network_key in the options.xml, can I just remove it from there and paste it in the configuration.yaml under zwave? zwave:
usb_path: /dev/ttyACM0
new_entity_ids: true
network_key: !secret zwave_network_key |
|
@arsaboo I am not entirely sure, but my gut tells me yes, you can do this. Please give it a shot and let us know! |
|
So, I commented out the network_key from options.xml and everything still works. |
|
Did you also add it to configuration as well or just comment it out? If the latter, I assume (although maybe @dale3h can comment), that it might continue to work but future devices cannot be added securely. I found that without a key, you will get an error/warning on startup pointing out that you do not have a key. |
|
I did add it to the configuration, as indicated in my previous post. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network key can be set here rather than in the (difficult to find) configuration
options.xml. It takes the same comma separated "0xNN" string syntax as previous.Description:
Pull request in home-assistant (if applicable): home-assistant/home-assistant#