Skip to content

Followup on rework modbus #28692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Followup on rework modbus #28692

merged 3 commits into from
Aug 28, 2023

Conversation

janiversen
Copy link
Member

@janiversen janiversen commented Aug 26, 2023

Proposed change

Added a link to the parameter usage in each entity section, so there are no excuse :-)

Removed "int" "uint", which have been deprecated for a year or more.

Remove "int8", "uint8" which have been allowed but never worked since Modbus uses 16 bit as minimum.

Both are still in the code, but will be removed, when the documentation have a been published a while.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Aug 26, 2023
@janiversen janiversen marked this pull request as draft August 26, 2023 13:40
@janiversen janiversen marked this pull request as ready for review August 26, 2023 14:55
@janiversen janiversen requested a review from c0ffeeca7 August 26, 2023 14:55
@janiversen
Copy link
Member Author

This PR is independent of the issue I raised a couple of hours ago:

#28691

That issue goes into the builder core.

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, @janiversen

@c0ffeeca7 c0ffeeca7 merged commit cd8d10f into home-assistant:current Aug 28, 2023
@janiversen
Copy link
Member Author

Just wondering if LGMT is a new way of saying LooksGood MeToo, since normally it's LooksGoodToMe 😀

You never know with all these modern expressions

@c0ffeeca7
Copy link
Contributor

c0ffeeca7 commented Aug 28, 2023

Just wondering if LGMT is a new way of saying LooksGood MeToo, since normally it's LooksGoodToMe 😀

You never know with all these modern expressions

haha, just a typo. :-D. Although I'm sure I'm looking great today.

@janiversen janiversen deleted the rework2 branch August 28, 2023 15:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants