Skip to content

Update opensky to clarify the attributes available in the events #28710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2023
Merged

Update opensky to clarify the attributes available in the events #28710

merged 3 commits into from
Aug 28, 2023

Conversation

coutadeurf
Copy link
Contributor

Proposed change

Updates documentation to clarify the attributes of the events and the defaulting of configuration

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • I've opened up a PR to add logo's and icons in Brands repository.
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@coutadeurf coutadeurf requested a review from joostlek as a code owner August 28, 2023 12:23
@home-assistant home-assistant bot added the current This PR goes into the current branch label Aug 28, 2023
joostlek
joostlek requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@home-assistant home-assistant bot marked this pull request as draft August 28, 2023 12:39
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@coutadeurf @joostlek
Update source/_integrations/opensky.markdown
244236d 
Typo correction (thanks joostlek!)

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
joostlek
joostlek reviewed Aug 28, 2023
View reviewed changes
joostlek
joostlek approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mark this as ready for review we can merge this :)

@coutadeurf coutadeurf marked this pull request as ready for review August 28, 2023 13:00
@home-assistant home-assistant bot requested a review from joostlek August 28, 2023 13:00
@joostlek joostlek changed the title Update opensky.markdown to clarify the attributes available in the events Update opensky to clarify the attributes available in the events Aug 28, 2023
@joostlek joostlek merged commit 7cf4b46 into home-assistant:current Aug 28, 2023
@joostlek
Copy link
Member

Thanks! :)

@coutadeurf coutadeurf deleted the patch-1 branch August 28, 2023 13:03
@coutadeurf
Copy link
Contributor Author

Thank you! First PR for me :)

@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek Awaiting requested review from joostlek joostlek is a code owner

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing attributes in entry event
2 participants
@coutadeurf @joostlek