Upnp update #2924
Merged
Upnp update #2924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance to pull request home-assistant/core#8067
|
@dgomes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @robbiet480, @fabaff and @fuga2136 to be potential reviewers. |
Landrash
requested changes
Jul 4, 2017
source/_components/upnp.markdown
Outdated
| @@ -14,7 +14,7 @@ ha_release: 0.18 | |||
|
|
|||
| The `upnp` component enables you to collect network statistics from your router such as bytes in/out and packets in/out. This information is provided by the Internet Gateway Device (IGD) Protocol if enabled on your router. | |||
|
|
|||
| The IGD can also automatically create port forwarding mappings on your router for Home Assistant. | |||
| The IGD can also automatically create port forwarding mappings on your router for Home Assistant. By default it port forwards the tcp port being used by Home Assistant (default 8123), this can be changed with the optional external_port parameter. | |||
There was a problem hiding this comment.
Documentation about configuration variables are missing.
Have a look at Google cast as an example.
source/_components/upnp.markdown
Outdated
| @@ -23,6 +23,7 @@ To integrate this into Home Assistant, add the following section to your `config | |||
| ```yaml | |||
| # Example configuration.yaml entry | |||
There was a problem hiding this comment.
Preferably update the description of this line.
Example:
# Example configuration.yaml entry with custom external port
source/_components/upnp.markdown
Outdated
| @@ -14,7 +14,7 @@ ha_release: 0.18 | |||
|
|
|||
| The `upnp` component enables you to collect network statistics from your router such as bytes in/out and packets in/out. This information is provided by the Internet Gateway Device (IGD) Protocol if enabled on your router. | |||
|
|
|||
| The IGD can also automatically create port forwarding mappings on your router for Home Assistant. | |||
| The IGD can also automatically create port forwarding mappings on your router for Home Assistant. By default it port forwards the tcp port being used by Home Assistant (default 8123), this can be changed with the optional external_port parameter. | |||
There was a problem hiding this comment.
Documentation about configuration variables are missing.
Landrash
approved these changes
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added new configuration option
Pull request in home-assistant (if applicable): home-assistant/core#8303