Skip to content

Optional variables added to sensor.cups.markdown #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2017

Conversation

trux66
Copy link
Contributor

@trux66 trux66 commented Jul 7, 2017

Sensor configuration supports two additional variables which are not listed but would be extremely helpful to anyone running their print server on a host other than the one running Home Assistant.

Added two lines to the Configuration variables section to show host and port optional values.

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

trux66 and others added 2 commits July 7, 2017 18:06
Sensor configuration supports two additional variables which are not listed but would be extremely helpful to anyone running their print server on a host other than the one running Home Assistant.

Added two lines to the Configuration variables section to show host and port optional values.
@Landrash
Copy link
Contributor

Landrash commented Jul 8, 2017

@trux66 Is this something that works now?

@Landrash Landrash added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jul 8, 2017
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged when information is verified.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff added Fix/Formatting/Language/Spelling and removed new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Jul 8, 2017
@fabaff fabaff merged commit 155c8c4 into home-assistant:current Jul 8, 2017
@trux66 trux66 deleted the patch-1 branch September 5, 2017 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants