Skip to content

Added documentation for the env_var tag in configuration files #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

devspacenine
Copy link
Contributor

Added documentation for the !env_var tag in configuration files, including a default value parameter as described in the pull request below.

Pull request in home-assistant: home-assistant/core#8484

@mention-bot
Copy link

@devspacenine, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @anchepiece and @ThinkPadNL to be potential reviewers.

@Landrash
Copy link
Contributor

@devspacenine Just for discussion. Wouldn't it be better to include this information here?

@fabaff
Copy link
Member

fabaff commented Jul 17, 2017

I tend to agree partially with @Landrash but I would suggest to go an additional step. The usage of !env_var is an advance feature thus we should place it under "Advanced Configuration" more as its own section than attaching it to "Storing Secrets".

@balloob balloob merged commit de4f348 into home-assistant:next Jul 24, 2017
@devspacenine devspacenine deleted the env_var_default branch July 24, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants