Skip to content

Add documentation on using credstash as a secret store #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

justin8
Copy link
Contributor

@justin8 justin8 commented Jul 16, 2017

Description: Add documentation for credstash support

Pull request in home-assistant (if applicable): home-assistant/core#8494

@mention-bot
Copy link

@justin8, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @kellerza to be potential reviewers.

@Landrash
Copy link
Contributor

I think this would be better suited for the ecosystem to avoid diluting the documentation with non base functionality?

@justin8
Copy link
Contributor Author

justin8 commented Jul 17, 2017

It appears that ecosystem is for functionality that is outside of core.

This works similar to keyring support for secrets, which is in core and in the paragraph above this documentation.

@fabaff
Copy link
Member

fabaff commented Jul 18, 2017

I guess that sooner or later we need to create a section for the scripts. I would be fine if we place it inside the "Storing Secrets" docs for now and move the keyring and the credstash later.

@justin8
Copy link
Contributor Author

justin8 commented Jul 18, 2017

+1 for that. It needs some cleanup, but that should be a separate CR. Right now it places it with the most logically similar information

@Landrash
Copy link
Contributor

Agree wth fabaff. Merging as is and in the future this might get moved,

@Landrash Landrash merged commit 6680c0d into home-assistant:next Jul 19, 2017
@MartinHjelmare
Copy link
Member

The parent PR is not merged yet.

@Landrash
Copy link
Contributor

Landrash commented Jul 19, 2017

My mistake, sorry about that. I'll revert this if it's not merged.

Landrash added a commit that referenced this pull request Jul 20, 2017
@balloob
Copy link
Member

balloob commented Jul 24, 2017

About to merge it, will revert the revert 👍

@justin8 justin8 deleted the credstash branch July 25, 2017 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants