Skip to content

Extends Pi-hole sensor to support the new monitored conditions #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2017
Merged

Extends Pi-hole sensor to support the new monitored conditions #3011

merged 2 commits into from
Jul 19, 2017

Conversation

tchellomello
Copy link
Contributor

@tchellomello tchellomello commented Jul 19, 2017 •
edited
Loading

Description:

Extends Pi-hole sensor to support the new monitored conditions

  • domains_being_blocked
  • queries_cached
  • queries_forwarded
  • unique_clients
  • unique_domains

Pull request in home-assistant (if applicable): home-assistant/core#8549

image

Example entry for configuration.yaml (if applicable):

#configuration.yaml
 - platform: pi_hole
   host: 192.168.0.1
   monitored_conditions:
    - dns_queries_today
    - ads_blocked_today
    - ads_percentage_today
    - domains_being_blocked
    - queries_cached
    - queries_forwarded
    - unique_clients
    - unique_domains

@tchellomello
Extends Pi-hole sensor to support the new sensors:
7125b33 
      - domains_being_blocked
      - queries_cached
      - queries_forwarded
      - unique_clients
      - unique_domains
@tchellomello tchellomello mentioned this pull request Jul 19, 2017
Merged
3 tasks
@tchellomello tchellomello changed the title Extends Pi-hole sensor to support the new sensors: Extends Pi-hole sensor to support the new monitored conditions Jul 19, 2017
@fabaff fabaff added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jul 19, 2017
fabaff
fabaff approved these changes Jul 19, 2017
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit be100c5 into home-assistant:next Jul 19, 2017
emlove added a commit that referenced this pull request Jul 19, 2017
@emlove
Revert " Extends Pi-hole sensor to support the new monitored conditio…
cdd3b9c 
…ns (#3011)"

This reverts commit be100c5.
emlove added a commit that referenced this pull request Jul 19, 2017
@emlove
Revert " Extends Pi-hole sensor to support the new monitored conditio…
e5f9293 
…ns (#3011)"

This reverts commit be100c5.
Landrash added a commit that referenced this pull request Jul 20, 2017
@Landrash
Revert " Extends Pi-hole sensor to support the new monitored conditio…
42410e9 
…ns (#3011)"

This reverts commit be100c5.
@tchellomello tchellomello deleted the extends_pi_hole branch July 21, 2017 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchellomello @fabaff