Late review on drop_connect docs #30527
Conversation
|
@pfrazer If you have time, please have a look. |
| {% details "Manual configuration steps" %} | ||
|
|
||
| - Browse to your Home Assistant instance. | ||
| - Go to **{% my integrations title="Settings > Devices & Services" %}**. | ||
| - Set up the new discovered devices. | ||
|
|
||
| {% enddetails %} |
There was a problem hiding this comment.
This needs to include our config_flow.md template file
There was a problem hiding this comment.
This integration is not set up by adding a config entry manually. Devices need to be discovered, and after that they can be set up. By adding the config_flow.md template the wrong instructions are shown.
There was a problem hiding this comment.
I ended using part of the template code.
There was a problem hiding this comment.
@frenck may be you can have another look as using config_flow.md is not appropriate here.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@jbouwh I'm on vacation until the 1st with amazingly bad internet, so my involvement for the time being may be limited to comments like this... I am fine with the changes that you made. The only detail I see that needs attention is the note at the end:
Change that to 'MQTT broker' or similar and it should be fine. |
Proposed change
Address late review comments on PR #29947.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.