Skip to content

Fix spelling mistakes and correct links in latest release notes #30546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 28, 2023
Merged

Fix spelling mistakes and correct links in latest release notes #30546

merged 4 commits into from
Dec 28, 2023

Conversation

joostlek
Copy link
Member

Proposed change

Fix spelling mistakes and correct links in latest release notes

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch rc This PR is against the RC branch labels Dec 28, 2023
@joostlek
Copy link
Member Author

Waiting on #30544 and #30545

@joostlek joostlek marked this pull request as ready for review December 28, 2023 21:01
joostlek
joostlek commented Dec 28, 2023
View reviewed changes
frenck
frenck reviewed Dec 28, 2023
View reviewed changes
frenck
frenck requested changes Dec 28, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small revert

@home-assistant home-assistant bot marked this pull request as draft December 28, 2023 21:03
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek @frenck
Update source/_posts/2024-01-03-release-20241.markdown
1ac6d29 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@joostlek joostlek marked this pull request as ready for review December 28, 2023 21:39
@home-assistant home-assistant bot requested a review from frenck December 28, 2023 21:39
frenck
frenck approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck merged commit 7364cb9 into home-assistant:rc Dec 28, 2023
@home-assistant home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Dec 28, 2023
@joostlek joostlek deleted the fixes branch December 28, 2023 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees

@joostlek joostlek

Labels
rc This PR is against the RC branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joostlek @frenck