Skip to content

Add docs for Sanix integration #30587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 30, 2024
Merged

Add docs for Sanix integration #30587

merged 9 commits into from
Apr 30, 2024

Conversation

tomaszsluszniak
Copy link
Contributor

@tomaszsluszniak tomaszsluszniak commented Dec 31, 2023 •
edited
Loading

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Dec 31, 2023
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 2, 2024
@home-assistant
Copy link

home-assistant bot commented Jan 2, 2024

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

This was referenced Jan 2, 2024
Merged
Merged
@home-assistant home-assistant bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jan 2, 2024
frenck
frenck requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comment above from the bot: This PR is targeting the wrong branch.

Please change the target branch of this PR to next and be sure to rebase your changes onto the upstream next branch as well.

../Frenck

@home-assistant
Copy link

home-assistant bot commented Jan 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 8, 2024 12:17
@tomaszsluszniak tomaszsluszniak changed the base branch from current to next January 8, 2024 12:20
@home-assistant home-assistant bot removed the current This PR goes into the current branch label Jan 8, 2024
@home-assistant home-assistant bot added needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Jan 8, 2024
@home-assistant
Copy link

home-assistant bot commented Jan 8, 2024

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@home-assistant home-assistant bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jan 8, 2024
@tomaszsluszniak tomaszsluszniak marked this pull request as ready for review January 8, 2024 12:22
@home-assistant home-assistant bot requested a review from frenck January 8, 2024 12:22
frenck
frenck previously requested changes Jan 8, 2024
View reviewed changes
source/_integrations/sanix.markdown Outdated
Comment on lines 26 to 28
As the `Device number` use your `Sanix dashboard` login.

To get the `Token`, go to the `Help` page, and `System version`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what is meant here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just information on how to get the API token for a config flow. I have changed it a bit

@home-assistant home-assistant bot marked this pull request as draft January 8, 2024 12:28
tomaszsluszniak and others added 2 commits January 8, 2024 21:50
@tomaszsluszniak @frenck
Apply suggestions from code review
7c00970 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@tomaszsluszniak
Add docs for Sanix integration
b1e642e
@tomaszsluszniak tomaszsluszniak marked this pull request as ready for review January 9, 2024 19:51
@home-assistant home-assistant bot requested a review from frenck January 9, 2024 19:51
@joostlek joostlek added the parent-merged The parent PR has been merged already label Apr 17, 2024
@frenck frenck added this to the 2024.5 milestone Apr 24, 2024
c0ffeeca7
c0ffeeca7 requested changes Apr 30, 2024
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft April 30, 2024 05:00
@tomaszsluszniak @c0ffeeca7
Apply suggestions from code review
cec6eca 
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@netlify Netlify
Copy link

netlify bot commented Apr 30, 2024 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit cec6eca
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/66307d728307360008466d17
😎 Deploy Preview https://deploy-preview-30587--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomaszsluszniak tomaszsluszniak marked this pull request as ready for review April 30, 2024 05:13
@home-assistant home-assistant bot requested a review from c0ffeeca7 April 30, 2024 05:13
c0ffeeca7
c0ffeeca7 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tomaszsluszniak 👍

@c0ffeeca7 c0ffeeca7 dismissed frenck’s stale review April 30, 2024 05:15

Requested change has been implemented

@c0ffeeca7 c0ffeeca7 merged commit abdf90e into home-assistant:next Apr 30, 2024
6 checks passed
@home-assistant home-assistant bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Apr 30, 2024
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Apr 30, 2024
frenck added a commit that referenced this pull request Apr 30, 2024
@tomaszsluszniak @frenck @c0ffeeca7
Add docs for Sanix integration (#30587)
9100d87 
* Add docs for Sanix integration

* Apply suggestions from code review

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

* Add docs for Sanix integration

* Add docs for Sanix integration

* Add docs for Sanix integration

* Apply suggestions from code review

Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>

---------

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

@frenck frenck Awaiting requested review from frenck

Assignees
No one assigned
Labels
cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Status: Done
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
4 participants
@tomaszsluszniak @frenck @c0ffeeca7 @joostlek