Skip to content

Add documentation for YR forecast data #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2017

Conversation

tinloaf
Copy link
Contributor

@tinloaf tinloaf commented Jul 26, 2017

Description:

Adds documentation for the yr.no forecast feature.

Pull request in home-assistant (if applicable): home-assistant/core#8650

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged when parent PR has been merged.

@frenck frenck self-assigned this Aug 29, 2017
@frenck
Copy link
Member

frenck commented Sep 2, 2017

@tinloaf The parent PR seems to merged some time ago, nevertheless, the documentation is still open since there is a merge conflict on it. Could you be so kind to resolve the conflict and make this PR mergeable? 👍

@frenck
Copy link
Member

frenck commented Sep 9, 2017

Fixed merge conflict.

@frenck frenck merged commit 90919e7 into home-assistant:current Sep 9, 2017
@Konstigt
Copy link

This line:

precipitation: The precipitation.

It must also explain over what period of time? Precipitation the next hour? 3 hour period? day?

@frenck
Copy link
Member

frenck commented Nov 21, 2017

@Konstigt This pull request is already closed. If you have any additional questions, please try our forum or Discord chat. In case you'd like to propose a change, feel free to open a PR.

@tinloaf
Copy link
Contributor Author

tinloaf commented Nov 21, 2017

@frenck Oh sorry - I just noticed this issue. No clue how I missed that this was still outstanding. Thanks for fixing!

@frenck
Copy link
Member

frenck commented Nov 21, 2017

@tinloaf No problem 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants