Skip to content

Add documentation for Dyson 360 Eye robot vacuum #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2017

Conversation

CharlesBlonde
Copy link
Contributor

Description:

Add documentation for Dyson 360 robot vacuum.

Pull request in home-assistant (if applicable): home-assistant/core#8852

One thing to note: The 2 others vacuums (iRobot and Xiaomi ) are in the ha_category Hub and not Vacuum. I don't know if it is a copy/paste error or if I'm misunderstanding this parameter.

@mention-bot
Copy link

@CharlesBlonde, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff to be a potential reviewer.

@MartinHjelmare
Copy link
Member

That should most likely be changed to Vacuum, as you say.

Copy link
Member

@azogue azogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and ready to merge

(I'll change the ha_category for the other two vacuums) --> #3150

@MartinHjelmare MartinHjelmare merged commit b8f4e46 into home-assistant:next Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants