Add delay feature to Threshold sensor #3168
Conversation
The threshold must be met constantly for on_delay or off_delay amount of time in order to switch to the respective state. Among other things, this allows turning an energy meter in to a "device is running" state, because it can ignore the small periods of time where the energy meter drops to zero.
|
@OverloadUT, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff and @Kernald to be potential reviewers. |
| @@ -39,4 +51,25 @@ Configuration variables: | |||
| - **threshold** (*Required*): The value which is the threshold. | |||
| - **type** (*Required*): `lower` if the value needs to be below the threshold or `upper` if higher. | |||
| - **name** (*Optional*): Name of the sensor to use in the frontend. Defaults to `Stats`. | |||
| - **on_delay** (*Optional*): The amount of time the threshold must be met before this sensor will switch to on | |||
There was a problem hiding this comment.
Missing punctuation at the end of sentence.
| @@ -39,4 +51,25 @@ Configuration variables: | |||
| - **threshold** (*Required*): The value which is the threshold. | |||
| - **type** (*Required*): `lower` if the value needs to be below the threshold or `upper` if higher. | |||
| - **name** (*Optional*): Name of the sensor to use in the frontend. Defaults to `Stats`. | |||
| - **on_delay** (*Optional*): The amount of time the threshold must be met before this sensor will switch to on | |||
| - **off_delay** (*Optional*): The amount of time the threshold must be not met before this sensor will switch to off | |||
There was a problem hiding this comment.
Missing punctuation at the end of sentence.
| @@ -9,7 +9,7 @@ sharing: true | |||
| footer: true | |||
| logo: home-assistant.png | |||
| ha_category: Binary Sensor | |||
| ha_iot_class: "Local Polling" | |||
| ha_iot_class: "Local Push" | |||
There was a problem hiding this comment.
Doesn't this sensor "poll" values from other sensors?
There was a problem hiding this comment.
I find the whole IoT Class a weird thing to have on the "meta-sensors" in general. But in this case it's listening to the sensor that it is monitoring, which is basically a push. This will react instantly to state changes rather than having to wait for a polling timer.
I feel like a new "Internal" IoT class is most appropriate, but that's a separate discussion. Perhaps the IoT class should be removed from this sensor entirely?
There was a problem hiding this comment.
Bringing it up in the #dev chat
| @@ -31,6 +31,18 @@ binary_sensor: | |||
| threshold: 15 | |||
| type: lower | |||
| entity_id: sensor.random | |||
|
|
|||
| # If present, sensor will only switch to on if the threshold is met for this amount of time | |||
There was a problem hiding this comment.
Missing punctuation at the end of sentence.
| minutes: 10 | ||
| seconds: 5 | ||
|
|
||
| # Same as above, but for the sensor switching to off |
There was a problem hiding this comment.
Missing punctuation at the end of sentence.
| This example uses `off_delay` to convert an energy meter connected to a washing machine to determine when a load is finished. During the washer's operation, the energy meter will fluctuate wildly, hitting zero frequently even before the load is finished. By utilizing `off_delay`, we can have this sensor only turn off if there has been no washer activity for 5 minutes. | ||
|
|
||
| ```yaml | ||
| # Determine when the washing machine has a load running |
There was a problem hiding this comment.
Missing punctuation at the end of sentence.
|
Closing PR, since parent PR has been closed. |
Description:
See home-assistant/core#8921
Pull request in home-assistant (if applicable): home-assistant/core#8921