Skip to content

Add information to install libffi-dev, needed for python-mirobo #3172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2017
Merged

Add information to install libffi-dev, needed for python-mirobo #3172

merged 2 commits into from
Aug 13, 2017

Conversation

olskar
Copy link
Contributor

@olskar olskar commented Aug 13, 2017 •
edited by azogue
Loading

Description:
libffi-dev is needed for home assistant to install python-mirobo.

Pull request in home-assistant (if applicable): home-assistant/core#8938

@mention-bot
Copy link

@olskar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @azogue to be a potential reviewer.

@olskar olskar mentioned this pull request Aug 13, 2017
Closed
azogue
azogue previously requested changes Aug 13, 2017
View reviewed changes
Copy link
Member

@azogue azogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about that dependency, thanks for your contribution, @olskar.

A minimal formatting change, please

source/_components/vacuum.xiaomi.markdown Outdated
@@ -20,6 +20,11 @@ Current supported features are `turn_on`, `pause`, `stop`, `return_to_home`, `tu

Follow the pairing process using your phone and Mi-Home app. From here you will be able to retrieve the token from a SQLite file inside your phone.

Before you begin you need to install libffi-dev by running the command below. This is needed for python-mirobi to be installed correctly.
```bash
$ apt-get install libffi-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the $ and it's good to go

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and if you encapsulate libffi-dev and python-mirobi to proper formatting, it would be perfect

@azogue azogue self-assigned this Aug 13, 2017
Landrash
Landrash approved these changes Aug 13, 2017
View reviewed changes
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both 🍪

@Landrash Landrash dismissed azogue’s stale review August 13, 2017 08:10

Added in requested changes before merge.

@Landrash Landrash merged commit 6baa22d into home-assistant:next Aug 13, 2017
@azogue
Copy link
Member

azogue commented Aug 13, 2017

👍

@olskar olskar deleted the patch-1 branch August 13, 2017 08:38
@sebdoan
Copy link
Contributor

sebdoan commented Aug 26, 2017

@syssi Thanks for updating the information on the component page, however I can't understand the instructions or for some reason they don't work for me. I'm running HASSBIAN so my HASS instance is running VirtualEnv.

When logged into my Raspbery Pi:

  1. I run "sudo apt-get install libffi-dev" and it all installs fine
  2. Then i run "sudo su -s /bin/bash homeassistant" then "source /srv/homeassistant/bin/activate", this all works fine and gets me into the VirtualEnv
  3. I assume what you mean by step 2 to to actually install libffi-dev in the VirtualEnv, but no combination of "pip install libffi-dev" or "apt-get install libffi-dev" actually works

And i still get the error as below. HELP???

[homeassistant.util.package] Unable to install package python-mirobo==0.1.2

@syssi
Copy link
Member

syssi commented Aug 26, 2017

There is another dependency which must be fulfilled (libssl-dev):

https://community.home-assistant.io/t/issue-config-xiaomi-vacuum-by-v0-51-1/24304/7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Landrash Landrash Landrash approved these changes

@azogue azogue azogue left review comments

Assignees

@azogue azogue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@olskar @mention-bot @azogue @sebdoan @syssi @Landrash