Skip to content

Usage of file directive for pushbullet #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2017
Merged

Conversation

tsvi
Copy link
Contributor

@tsvi tsvi commented Aug 21, 2017

Description:
This is the missing documentation for PR#8763 in home assistant

Pull request in home-assistant (if applicable): home-assistant/core#8763

This is the missing documentation for PR#8763 in home assistant
@mention-bot
Copy link

@tsvi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Found some grammar and spelling errors.

- **file** (*Required*): File to send with pushbullet.

<p class='note'>
If the path to the file is located in an external directory, it has to be whitelisted so homeassistant has access to it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar:

  • It appears that you are missing a comma before so.
    -> it has to be whitelisted, so

Spelling:

  • homeassistant -> Home Assistant

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thank you for rephrasing 👍

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 47b6c84 into home-assistant:current Aug 21, 2017
@tsvi tsvi deleted the patch-1 branch August 21, 2017 12:43
fabaff pushed a commit that referenced this pull request Aug 25, 2017
* Usage of file directive for pushbullet

This is the missing documentation for PR#8763 in home assistant

* Fix spelling and grammar

* Replace sample with link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants