Skip to content

Fix URL typo in ambient_network docs #32497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix URL typo in ambient_network docs #32497

merged 1 commit into from
Apr 29, 2024

Conversation

chrisx8
Copy link
Contributor

@chrisx8 chrisx8 commented Apr 28, 2024

Proposed change

Correct a typo in Ambient Network's URL - it's missing an a.

Targeting rc branch as this integration (ambient_network) is currently in 2024.5 beta.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch rc This PR is against the RC branch labels Apr 28, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@netlify Netlify
Copy link

netlify bot commented Apr 28, 2024 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 02201dd
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/662f96c80fa91900087b7e70
😎 Deploy Preview https://deploy-preview-32497--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chrisx8
Copy link
Contributor Author

chrisx8 commented Apr 28, 2024

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch.

Targeting rc branch as ambient_network integration, and this typo, is currently in 2024.5 beta.

@c0ffeeca7
Copy link
Contributor

c0ffeeca7 commented Apr 29, 2024 •
edited
Loading

Thank you for the catch, @chrisx8 👍
We don't usually push to rc. Please base against next

@chrisx8 chrisx8 requested a review from a team as a code owner April 29, 2024 12:47
@chrisx8 chrisx8 changed the base branch from rc to next April 29, 2024 12:47
@home-assistant home-assistant bot added next This PR goes into the next branch and removed rc This PR is against the RC branch labels Apr 29, 2024
c0ffeeca7
c0ffeeca7 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @chrisx8 👍

@c0ffeeca7 c0ffeeca7 added this to the 2024.5 milestone Apr 29, 2024
@c0ffeeca7 c0ffeeca7 merged commit aaa27b3 into home-assistant:next Apr 29, 2024
6 checks passed
@home-assistant home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Apr 29, 2024
@chrisx8 chrisx8 deleted the rc branch April 29, 2024 14:29
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Apr 30, 2024
frenck pushed a commit that referenced this pull request Apr 30, 2024
@chrisx8 @frenck
Fix URL typo in ambient_network docs (#32497)
fa61fea
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

Assignees

@chrisx8 chrisx8

Labels
cherry-picked This PR has been manually picked and merged into the current branch next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Status: Done
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisx8 @c0ffeeca7 @frenck