Skip to content

OpenWeatherMap remove obsolete forecast sensors #33320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024
Merged

OpenWeatherMap remove obsolete forecast sensors #33320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions source/_integrations/openweathermap.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ For more details, set limits on your usage to avoid charges at [OpenWeatherMap S

<div class='note'>

If you register an new API key with OpenWeatherMap, it will be activated automatically, this typically takes between 10 minutes and 2 hours
after your successful registration. Keep in mind when configuring this integration, that you new API key might
If you register a new API key with OpenWeatherMap, it will be activated automatically, this typically takes between 10 minutes and 2 hours
after your successful registration. Keep in mind when configuring this integration, that your new API key might
Comment on lines +47 to +48
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note about API key activation could be made clearer.

Consider rephrasing for clarity and conciseness:

- If you register a new API key with OpenWeatherMap, it will be activated automatically, this typically takes between 10 minutes and 2 hours after your successful registration. Keep in mind when configuring this integration, that your new API key might not be activated yet.
+ When registering a new API key with OpenWeatherMap, activation typically occurs within 10 minutes to 2 hours. Ensure the key is active before using it in this integration.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
If you register a new API key with OpenWeatherMap, it will be activated automatically, this typically takes between 10 minutes and 2 hours
after your successful registration. Keep in mind when configuring this integration, that your new API key might
If you register a new API key with OpenWeatherMap, it will be activated automatically, this typically takes between 10 minutes and 2 hours
after your successful registration. Keep in mind when configuring this integration, that your new API key might
When registering a new API key with OpenWeatherMap, activation typically occurs within 10 minutes to 2 hours. Ensure the key is active before using it in this integration.
Tools
LanguageTool

[misspelling] ~47-~47: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...e'> If you register a new API key with OpenWeatherMap, it will be activated automatically, th...

[typographical] ~48-~48: Make sure that the comma (,) is correct. Do not use a comma before a dependent clause that starts with ‘that’. (COMMA_THAT_NOUN)
Context: ...n mind when configuring this integration, that your new API key might not be activated...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to fix small mistakes, not rephrase whole section.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freekode, understood! I've noted your preference for focusing on minor corrections. The suggested changes have been adjusted to address just the small errors as you intended. If there's anything else you need, feel free to let me know!

not be activated yet. Recent policy changes limit the API access for new registered users with a free plan, they should select the `hourly` mode. The other modes require a paid subscription plan. Invalid API-key errors might occur if your API key is used with the other modes.

</div>
Expand All @@ -61,7 +61,7 @@ not be activated yet. Recent policy changes limit the API access for new registe
| Mode | API version, `v2.5` (deprecated), `v3.0` new API version. |
| Language | Language for receiving data (only for `sensor`) |

A `sensor` entity will be created for each supported condition. Their ids will follow the format:
A `sensor` entity will be created for each supported condition. Their IDs will follow the format:

`sensor.<integration name>_<monitored condition>`

Expand Down Expand Up @@ -94,21 +94,6 @@ The Weather entity provides data only in English. Home Assistant automatically t
| `weather` | A human-readable description of the [weather condition](https://openweathermap.org/weather-conditions#Weather-Condition-Codes-2). |
| `weather_code` | ID of the [weather condition](https://openweathermap.org/weather-conditions#Weather-Condition-Codes-2). |
| `wind_bearing` | Wind direction, degrees (meteorological). |
| `wind_speed` | Wind speed, metre/sec. |

### Forecast Weather Conditions

| Condition | Description |
| :----------------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `forecast_cloud_coverage` | Cloudiness, %. |
| `forecast_condition` | [Weather condition](https://developers.home-assistant.io/docs/core/entity/weather/#recommended-values-for-state-and-condition) for the forecast's time period. |
| `forecast_precipitation` | Combined Rain and Snow volume for the forecast's time period, mm. |
| `forecast_precipitation_probability` | Probability of precipitation for the forecast's time period. |
| `forecast_pressure` | Atmospheric pressure at sea level for the forecast's time period, hPa. |
| `forecast_temperature` | Maximum temperature for the day. |
| `forecast_temperature_low` | Minimum temperature for the day. |
| `forecast_time` | Time of the forecasted data. |
| `forecast_wind_bearing` | Wind direction for the forecast's time period, degrees (meteorological). |
| `forecast_wind_speed` | Wind speed for the forecast's time period, metre/sec. |
| `wind_speed` | Wind speed, meter/sec. |

Details about the API are available in the [OpenWeatherMap documentation](https://openweathermap.org/api).