Skip to content

Update tplink documentation for next release #33342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Jun 21, 2024

Proposed change

Update tplink docs for next release

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features

    • Expanded support for new device categories in the tplink_tapo integration, including Binary Sensor, Button, Climate, Fan, Number, and Select.
    • Updated light effects support, including new details for Kasa bulbs and services for setting random and sequence effects on light strips.
  • Documentation

    • Revised supported device listings to refer to external sources for the most current information.
    • Included footnotes for devices requiring authentication and cross-brand hub compatibility.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Jun 21, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 7ec7611
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/667bb388cfb924000858d8b4
😎 Deploy Preview https://deploy-preview-33342--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jun 21, 2024
@rytilahti
Copy link
Member

@sdb9696 when we are that far, please sync the platforms into this one single PR as it makes no sense to do what I just did earlier... :-)

@bdraco bdraco added the parent-merged The parent PR has been merged already label Jun 25, 2024
@sdb9696 sdb9696 marked this pull request as ready for review June 26, 2024 06:13
Copy link
Contributor

coderabbitai bot commented Jun 26, 2024

Warning

Rate limit exceeded

@sdb9696 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 50 minutes and 56 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 50f386c and 7ec7611.

Walkthrough

The recent changes focus on expanding the device categories and platform support for both tplink and tplink_tapo integrations. Key updates include adding support for Binary sensor, Button, Climate, Fan, Number, and Select device categories. Additionally, there are adjustments to code owner declarations and the supported devices lists.

Changes

File Change Summary
source/_integrations/tplink.markdown Added support for new device categories (Fan, Number, Select), updated supported devices list, and added new information on light effects.
source/_integrations/tplink_tapo.markdown Added support for new device categories (Binary sensor, Button, Climate, Fan, Number, Select), updated platforms, and removed Hub.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bdraco bdraco removed the in-progress This PR/Issue is currently being worked on label Jun 26, 2024
bdraco
bdraco previously approved these changes Jun 26, 2024
@sdb9696 sdb9696 force-pushed the update_tplink_docs branch from 454bd09 to 7ec7611 Compare June 26, 2024 06:21
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

@bdraco bdraco merged commit bd84a14 into home-assistant:next Jun 26, 2024
6 checks passed
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Jun 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
@sdb9696 sdb9696 deleted the update_tplink_docs branch November 22, 2024 10:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants