Skip to content

Add button platform for tplink #33367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add button platform for tplink #33367

wants to merge 1 commit into from

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Jun 22, 2024 •
edited by coderabbitai bot
Loading

Proposed change

Add button platform for tplink.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features
    • Added 'Button' category to the TP-Link Smart Home integration.
    • Added 'button' platform to the TP-Link Smart Home integration.

@rytilahti rytilahti requested a review from bdraco as a code owner June 22, 2024 15:40
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jun 22, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 22, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent changes to the TP-Link Smart Home integration extend its functionality by adding support for the 'Button' category. Consequently, the 'button' platform has been introduced to both the general TP-Link integration and the TP-Link Tapo integration, enhancing their capabilities to recognize and manage button devices.

Changes

File Change Summary
source/_integrations/tplink.markdown Added 'Button' to ha_category and 'button' to ha_platforms.
tplink_tapo.markdown Added - Button to ha_category and - button to ha_platforms.
Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 60b7124 and 0f76030.

Files selected for processing (2)
  • source/_integrations/tplink.markdown (2 hunks)
  • source/_integrations/tplink_tapo.markdown (2 hunks)
Additional context used
LanguageTool
source/_integrations/tplink.markdown

[misspelling] ~30-~30: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ..._integration_type: integration --- The tplink integration allows you to control your...

[misspelling] ~30-~30: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ion allows you to control your [TP-Link Kasa Smart Home Devices](https://www.tp-link...

[misspelling] ~30-~30: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...w.tp-link.com/kasa-smart/) and TP-Link Tapo Devices such as...

[misspelling] ~32-~32: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...tion. This can be done either by using [kasa command-line tool](https://python-kasa....

[misspelling] ~32-~32: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ioning) or by adding it to the official Kasa or Tapo app before trying to add them t...

[misspelling] ~32-~32: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...or by adding it to the official Kasa or Tapo app before trying to add them to Home A...

[misspelling] ~34-~34: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...e Assistant. If your device is a newer Kasa or Tapo device it will require your TP-...

[misspelling] ~34-~34: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ant. If your device is a newer Kasa or Tapo device it will require your TP-Link clo...

[misspelling] ~41-~41: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...rted Devices See [Supported Devices in python-kasa](https://github.com/python-kasa/python-...

[uncategorized] ~41-~41: It appears that hyphens are missing in the adjective “up-to-date”. (UP_TO_DATE_HYPHEN)
Context: ...a/python-kasa#supported-devices) for an up to date list. Devices not listed below may wor...

[uncategorized] ~43-~43: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...list. Devices not listed below may work but if you encounter issues submit a bug re...

[misspelling] ~43-~43: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ncounter issues submit a bug report to [python-kasa](https://github.com/python-kasa/python-...

[misspelling] ~145-~145: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...he light strip to set the effect on | | init_states | Initial HSV sequence | | `bac...

[misspelling] ~151-~151: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ation | | transition | Transition | | fadeoff | Fade off | | hue_range | Range of ...

Additional comments not posted (4)
source/_integrations/tplink_tapo.markdown (2)

5-5: Approve addition of 'Button' to ha_category.

The addition of the 'Button' category aligns with the PR's objective to support a new button platform for TP-Link devices.

22-22: Approve addition of 'button' to ha_platforms.

Adding the 'button' platform to the ha_platforms list correctly implements the new functionality described in the PR.

source/_integrations/tplink.markdown (2)

5-5: Approve addition of 'Button' to ha_category.

The inclusion of the 'Button' category in ha_category is consistent with the PR's goal to expand the functionality of TP-Link integrations to include button controls.

20-20: Approve addition of 'button' to ha_platforms.

The addition of the 'button' platform to ha_platforms correctly implements the new functionality as described, facilitating the control of TP-Link devices via button interactions in Home Assistant.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Jun 22, 2024 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 0f76030
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6676f054e3f41b000879cab3
😎 Deploy Preview https://deploy-preview-33367--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rytilahti rytilahti mentioned this pull request Jun 22, 2024
Merged
21 tasks
@rytilahti rytilahti marked this pull request as draft June 22, 2024 16:45
@rytilahti
Copy link
Member Author

Should be done in #33342

@rytilahti rytilahti closed this Jun 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rytilahti