Skip to content

Create device_tracker.hitron_coda.markdown #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2017

Conversation

arilotter
Copy link
Contributor

@arilotter arilotter commented Oct 4, 2017

Description:
Add docs for new device tracker (hitron CODA)

Pull request in home-assistant (if applicable): home-assistant/core#9682

@fabaff fabaff added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-integration This PR adds documentation for a new Home Assistant integration labels Oct 4, 2017
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arilotter Found some really minor grammar issues, could you please take a look? Thx!

---
layout: page
title: "Hitron CODA Routers"
description: "Instructions how to integrate Hitron CODA Routers into Home Assistant."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling & Grammar:

  • Instructions how to -> Instructions on how to


Configuration variables:

- **host** (*Required*): The IP address of your router, e.g. 192.168.0.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling & Grammar:

  • Missing comma after e.g. -> your router, e.g., 192.168.0.1

Configuration variables:

- **host** (*Required*): The IP address of your router, e.g. 192.168.0.1.
- **username** (*Required*): The username to login into the router (user should have read access to web interface of the router). Usually "cusadmin".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling & Grammar:

  • to web interface -> to the web interface

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @arilotter! Can be merged as soon as parent PR gets merged. 🏅

footer: true
logo: keenetic.png
ha_category: Presence Detection
ha_release: 0.55
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.58

comments: false
sharing: true
footer: true
logo: keenetic.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale logo.

password: !secret router_password
```

Configuration variables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck frenck removed the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Nov 14, 2017
@frenck
Copy link
Member

frenck commented Nov 14, 2017

@arilotter Since the parent PR has been merged, we hope to be able to merge the documentation as well. Could you please take a look at the comments left behind by @MartinHjelmare? Thx 🏅

@frenck frenck added this to the 0.58 milestone Nov 18, 2017
@frenck frenck self-assigned this Nov 18, 2017
@frenck
Copy link
Member

frenck commented Nov 18, 2017

v0.58 is getting close and no response from the author. I will be updating this PR myself.

@frenck frenck dismissed MartinHjelmare’s stale review November 18, 2017 08:47

Updated PR and preparing for v0.58 release

@frenck frenck merged commit 837168d into home-assistant:next Nov 18, 2017
@arilotter
Copy link
Contributor Author

Hey @frenck, I left a comment on the review because I was confused about how to implement the {% configuration %} tag. Thanks for updating the PR yourself!

@frenck
Copy link
Member

frenck commented Nov 18, 2017

@arilotter No problem! There is a little deadline, so that's why I did it.

balloob pushed a commit that referenced this pull request Nov 18, 2017
* Create device_tracker.hitron_coda.markdown

* Fix minor grammar issues

* 🔨 Processed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants