-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Create device_tracker.hitron_coda.markdown #3512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arilotter Found some really minor grammar issues, could you please take a look? Thx!
--- | ||
layout: page | ||
title: "Hitron CODA Routers" | ||
description: "Instructions how to integrate Hitron CODA Routers into Home Assistant." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling & Grammar:
Instructions how to
->Instructions on how to
|
||
Configuration variables: | ||
|
||
- **host** (*Required*): The IP address of your router, e.g. 192.168.0.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling & Grammar:
- Missing comma after
e.g.
->your router, e.g., 192.168.0.1
Configuration variables: | ||
|
||
- **host** (*Required*): The IP address of your router, e.g. 192.168.0.1. | ||
- **username** (*Required*): The username to login into the router (user should have read access to web interface of the router). Usually "cusadmin". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling & Grammar:
to web interface
->to the web interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @arilotter! Can be merged as soon as parent PR gets merged. 🏅
footer: true | ||
logo: keenetic.png | ||
ha_category: Presence Detection | ||
ha_release: 0.55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.58
comments: false | ||
sharing: true | ||
footer: true | ||
logo: keenetic.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale logo.
password: !secret router_password | ||
``` | ||
|
||
Configuration variables: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the new configuration tag.
https://home-assistant.io/developers/documentation/standards/#component-and-platform-pages
@arilotter Since the parent PR has been merged, we hope to be able to merge the documentation as well. Could you please take a look at the comments left behind by @MartinHjelmare? Thx 🏅 |
v0.58 is getting close and no response from the author. I will be updating this PR myself. |
Updated PR and preparing for v0.58 release
Hey @frenck, I left a comment on the review because I was confused about how to implement the {% configuration %} tag. Thanks for updating the PR yourself! |
@arilotter No problem! There is a little deadline, so that's why I did it. |
* Create device_tracker.hitron_coda.markdown * Fix minor grammar issues * 🔨 Processed review comments
Description:
Add docs for new device tracker (hitron CODA)
Pull request in home-assistant (if applicable): home-assistant/core#9682