Update docs with emulated_hue_hidden #3554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Emulated_hue_hidden: false in the doco implies it is not hidden. Before this change the config was emulated_hue: false to not add to emulated hue. Now you mark hidden as false to hide it, whereas logic dictates that if hidden is false, it is not hidden. Therefore the comment in the doco needs to make it clear which is which. |
|
Based on this: home-assistant/core#9382 (comment) I believe this pull request as written is incorrect. It should be emulated_hue: false becomes emulated_hue_hidden: true |
kipwittchen
reviewed
Oct 9, 2017
| @@ -96,15 +96,15 @@ homeassistant: | |||
| customize: | |||
| light.bedroom_light: | |||
| # Don't allow light.bedroom_light to be controlled by the emulated Hue bridge | |||
| emulated_hue: false | |||
| emulated_hue_hidden: false | |||
There was a problem hiding this comment.
Should this be emulated_hue_hidden: true ?
jhaals
added a commit
to jhaals/home-assistant.github.io
that referenced
this pull request
Oct 23, 2017
this will make the setting correspond to the comment above. This is also noticed after merge in home-assistant#3554
fabaff
pushed a commit
that referenced
this pull request
Oct 24, 2017
this will make the setting correspond to the comment above. This is also noticed after merge in #3554
fabaff
pushed a commit
that referenced
this pull request
Oct 31, 2017
this will make the setting correspond to the comment above. This is also noticed after merge in #3554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add docs for this pr: home-assistant/core#9382