Skip to content

Tahoma Platform #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 20, 2017
Merged

Tahoma Platform #3574

merged 5 commits into from
Nov 20, 2017

Conversation

philklei
Copy link
Contributor

@philklei philklei commented Oct 9, 2017 •
edited by MartinHjelmare
Loading

Description:

Success of #3002.

Pull request in home-assistant (if applicable):
home-assistant/core#10652

@fabaff fabaff added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-integration This PR adds documentation for a new Home Assistant integration labels Oct 9, 2017
@philklei philklei mentioned this pull request Oct 9, 2017
Closed
8 tasks
@fabaff fabaff removed the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Nov 6, 2017
@philklei philklei mentioned this pull request Nov 18, 2017
Merged
8 tasks
frenck
frenck requested changes Nov 18, 2017
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philklei I've reviewed your PR and have some minor comments. Could you please take a look?

source/_components/tahoma.markdown Outdated
exclude: [BridgeHUEComponent, HueLampHUEComponent, PodComponent]
```

Configuration variables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags as described in our documentation guidelines:

For more information please visit:
https://home-assistant.io/developers/documentation/create_page/#configuration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck updated!

source/_components/tahoma.markdown Outdated
---


The `Tahoma` component platform is used as an interface to the [tahomalink.com](https://www.tahomalink.com) website. It adds actually covers and the sun sensor from tahoma plattform.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: plattform -> platform.

The last sentence is not quite right. I would suggest removing it or maybe reword it?
Suggestion: It adds covers and the sun sensor from tahoma platform.

frenck
frenck previously approved these changes Nov 19, 2017
View reviewed changes
@frenck
Copy link
Member

frenck commented Nov 19, 2017

@philklei 🏅
Can be merged as soon as the parent PR gets merged.
Note: Version needs to be updated as soon as the parent gets merged.

MartinHjelmare
MartinHjelmare reviewed Nov 19, 2017
View reviewed changes
source/_components/tahoma.markdown Outdated
exclude: [BridgeHUEComponent, HueLampHUEComponent, PodComponent]
```

Configuration variables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this header since you have implemented the configuration tag instead.

source/_components/tahoma.markdown Outdated
footer: true
logo: somfy.png
ha_category: Hub
ha_release: 0.41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.59

source/_components/sensor.tahoma.markdown Outdated
footer: true
logo: tahoma.png
ha_category: Cover
ha_release: 0.41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.59

source/_components/cover.tahoma.markdown Outdated
footer: true
logo: tahoma.png
ha_category: Cover
ha_release: 0.41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.59

@philklei
Copy link
Contributor Author

@MartinHjelmare update files

MartinHjelmare
MartinHjelmare previously approved these changes Nov 19, 2017
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

MartinHjelmare
MartinHjelmare reviewed Nov 19, 2017
View reviewed changes
source/_components/cover.tahoma.markdown
comments: false
sharing: true
footer: true
logo: tahoma.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be a logo named tahoma.png. Am I wrong?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right!
@philklei ?

source/_components/sensor.tahoma.markdown
comments: false
sharing: true
footer: true
logo: tahoma.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above.

frenck
frenck requested changes Nov 20, 2017
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking accidental merge of this PR by dismissing approval.
@philklei Please take a look at the above feedback from @MartinHjelmare.

MartinHjelmare
MartinHjelmare approved these changes Nov 20, 2017
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frenck
Copy link
Member

frenck commented Nov 20, 2017

@philklei, thank you for updating the PR! 🏅

@frenck frenck merged commit 78f4332 into home-assistant:next Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philklei @frenck @MartinHjelmare @fabaff