Skip to content

Script - wait_template 'trigger.entity_id' support #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2017
Merged

Script - wait_template 'trigger.entity_id' support #3593

merged 3 commits into from
Oct 21, 2017

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 12, 2017

Description:
Added trigger.entity_id and variables support for wait_template

Pull request in home-assistant: home-assistant/core#9807

@fabaff fabaff added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Oct 12, 2017
@fabaff fabaff changed the base branch from current to next October 12, 2017 15:29
@fabaff fabaff changed the base branch from next to current October 12, 2017 15:30
@fabaff fabaff added this to the 0.56 milestone Oct 12, 2017
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

@frenck
Copy link
Member

frenck commented Oct 18, 2017

@cdce8p Could you please rebase this one onto the next branch?

@@ -98,7 +98,7 @@ wait_template: "{{ is_state(trigger.entity_id, 'on') }}"
```
{% endraw %}

It is also possible to use dummy variables, e.g. in scripts, when using `wait_template`.
It is also possible to use dummy variables, e.g., in scripts, when using `wait_template`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out Link. Both versions are possible. I just tend to like the British one better.

Copy link
Member

@frenck frenck Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK to like the British one better, but we have a policy on using American English only.

@cdce8p
Copy link
Member Author

cdce8p commented Oct 18, 2017

@frenck I would suggest to leave it at current and just merge it after the next version of HA is public. Since it is only an extension to the current functions and not a new platform, I figured that nextwould not be right here.

@fabaff fabaff merged commit e873345 into home-assistant:current Oct 21, 2017
@cdce8p cdce8p deleted the wait_template_trigger branch October 22, 2017 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants