Skip to content

Added documentation for new cold_tolerance and hot_tolerance configs for generic_thermostat #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2017
Merged

Added documentation for new cold_tolerance and hot_tolerance configs for generic_thermostat #3600

merged 1 commit into from
Oct 31, 2017

Conversation

biggms
Copy link
Contributor

@biggms biggms commented Oct 13, 2017 •
edited
Loading

Description:
Individual cold and hot tolerance settings for generic_thermostat.
This PR removes documentation for the single "tolerance" config and replaces it with "cold_tolerance" and "hot_tolerance".
Sample configuration has been corrected to match new configs

Pull request in home-assistant: home-assistant/core#9843

@biggms biggms mentioned this pull request Oct 13, 2017
Merged
8 tasks
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Oct 18, 2017
frenck
frenck approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great first-time contribution @biggms! 🎖

Can be merged as soon as the parent PR is merged.

fabaff
fabaff approved these changes Oct 31, 2017
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 62ee6e1 into home-assistant:next Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biggms @fabaff @frenck