Skip to content

Add actions to Music Assistant #36469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Add actions to Music Assistant #36469

merged 2 commits into from
Dec 23, 2024

Conversation

OzGav
Copy link
Contributor

@OzGav OzGav commented Dec 21, 2024

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features
    • Introduced music_assistant.search action for global media searches with various customizable attributes.
    • Added music_assistant.get_library action for local library searches with enhanced filtering options.
    • Implemented music_assistant.get_queue action for retrieving the current media queue.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Dec 21, 2024
Copy link

netlify bot commented Dec 21, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 796923e
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67673441917d740008201979
😎 Deploy Preview https://deploy-preview-36469--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Dec 21, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request updates the Music Assistant integration documentation by introducing three new actions: music_assistant.search, music_assistant.get_library, and music_assistant.get_queue. These actions provide enhanced functionality for searching and interacting with music libraries, allowing users to perform global and local searches, retrieve library contents, and access queue information with various configurable parameters.

Changes

File Change Summary
source/_integrations/music_assistant.markdown Added documentation for three new actions:
- music_assistant.search: Global library search with attributes like config_entry_id, name, media_type, etc.
- music_assistant.get_library: Local library search with attributes such as config_entry_id, media_type, favorite, etc.
- music_assistant.get_queue: Queue retrieval action with entity_id attribute

Sequence Diagram

sequenceDiagram
    participant User
    participant MusicAssistant
    participant Library
    
    User->>MusicAssistant: music_assistant.search
    MusicAssistant->>Library: Perform global search
    Library-->>MusicAssistant: Return search results
    MusicAssistant-->>User: Display search results

    User->>MusicAssistant: music_assistant.get_library
    MusicAssistant->>Library: Retrieve local library content
    Library-->>MusicAssistant: Return library items
    MusicAssistant-->>User: Show library contents
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
source/_integrations/music_assistant.markdown (3)

144-144: Fix grammar in description

There's a minor grammatical error in the description.

-  - **Description**: The Music Assistant instance that the searched will be performed upon. Allows for multiple servers to be running.
+  - **Description**: The Music Assistant instance that the search will be performed upon. Allows for multiple servers to be running.

185-185: Add missing comma in description

Add a comma after "selected" for better readability.

-  - **Description**: When selected only items marked as favorites will be returned.
+  - **Description**: When selected, only items marked as favorites will be returned.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~185-~185: Possible missing comma found.
Context: ...ional**: Yes. - Description: When selected only items marked as favorites will be ...

(AI_HYDRA_LEO_MISSING_COMMA)


200-202: Enhance the order_by parameter documentation

The reference to Developer Tools could be more specific to help users locate the options.

-  - **Description**: Sort the list by this field. The options are numerous so inspect them in the Developer Tools, Actions tab.
+  - **Description**: Sort the list by this field. View available sorting options in the Developer Tools > Services > music_assistant.get_library action.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2422aa8 and 08539ce.

📒 Files selected for processing (1)
  • source/_integrations/music_assistant.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/music_assistant.markdown

[uncategorized] ~185-~185: Possible missing comma found.
Context: ...ional**: Yes. - Description: When selected only items marked as favorites will be ...

(AI_HYDRA_LEO_MISSING_COMMA)

🔇 Additional comments (3)
source/_integrations/music_assistant.markdown (3)

138-170: LGTM! Well-documented search action

The documentation for the music_assistant.search action is comprehensive and follows the established pattern. All parameters are clearly documented with good examples.


212-220: LGTM! Clear and concise queue action documentation

The documentation for the music_assistant.get_queue action is well-structured and provides all necessary information.


138-220: Verify integration with Home Assistant Core

The documentation aligns well with the PR objectives. Let's verify the action names match those in the core implementation.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~185-~185: Possible missing comma found.
Context: ...ional**: Yes. - Description: When selected only items marked as favorites will be ...

(AI_HYDRA_LEO_MISSING_COMMA)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
source/_integrations/music_assistant.markdown (3)

138-170: Consider documenting the response format.

The documentation for the music_assistant.search action is well-structured, but it would be helpful to include information about the expected response format. This would help users understand what data they'll receive and how to handle it in their automations.

Consider adding a section like:

- **Example**: `true`
+  - **Example**: `true`
+
+#### Response format
+
+The action returns a dictionary containing search results grouped by media type:
+```yaml
+{
+  "tracks": [...],
+  "albums": [...],
+  "artists": [...],
+  "playlists": [...],
+  "radio": [...]
+}
+```

199-202: List available order_by options in the documentation.

Instead of directing users to check Developer Tools for available sorting options, it would be more user-friendly to list them directly in the documentation.

Consider expanding the documentation like:

- **Description**: Sort the list by this field. View available sorting options in the Developer Tools > Actions > music_assistant.get_library action.
+ **Description**: Sort the list by this field. Available options:
+   - For tracks: name, artist, album, duration, year
+   - For albums: name, artist, year
+   - For artists: name
+   - For playlists: name, owner
+   - For radio: name

212-220: Enhance the get_queue action documentation.

The documentation for the music_assistant.get_queue action could be more comprehensive. Consider adding:

  1. The response format and structure
  2. Any optional parameters if they exist
  3. Example response payload

Consider expanding the documentation like:

  - **Example**: `media_player.kitchen_speaker`

+ #### Response format
+
+ The action returns the queue details including:
+ ```yaml
+ {
+   "current_item": {...},  # Currently playing item
+   "items": [...],         # List of queued items
+   "total_items": 10,      # Total number of items in queue
+   "current_index": 0      # Index of current item
+ }
+ ```
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 08539ce and 796923e.

📒 Files selected for processing (1)
  • source/_integrations/music_assistant.markdown (1 hunks)
🔇 Additional comments (1)
source/_integrations/music_assistant.markdown (1)

138-220: Documentation looks good overall!

The documentation for the three new actions is well-structured, follows Home Assistant's documentation style, and provides clear examples. The suggested improvements above would enhance the documentation further, but the current version is already valuable and ready to be merged.

@frenck frenck added the parent-merged The parent PR has been merged already label Dec 23, 2024
@marcelveldt
Copy link
Member

One thing I'm not sure of is if we should also add the expected output as these actions have return values. @frenck ?

@frenck
Copy link
Member

frenck commented Dec 23, 2024

I think that would be a nice bonus @marcelveldt, but that can also be a follow up PR (considering beta cut is around the corner).

Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @OzGav !

@frenck frenck merged commit 3750738 into home-assistant:next Dec 23, 2024
7 checks passed
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Dec 23, 2024
@OzGav OzGav deleted the next branch December 23, 2024 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
@marcelveldt
Copy link
Member

@c0ffeeca7 any idea why this change doesnt show up in the current stable docs ?
Maybe it got missed while cherry picking ?

@c0ffeeca7
Copy link
Contributor

@c0ffeeca7 any idea why this change doesnt show up in the current stable docs ? Maybe it got missed while cherry picking ?

#36784

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants