Skip to content

Fix steps. Backups are always encrypted #36677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

c0ffeeca7
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 commented Jan 3, 2025

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated backup documentation for Home Assistant.
    • Clarified instructions for creating, restoring, and managing backups.
    • Emphasized that all backups are encrypted and highlighted the backup emergency kit.
    • Streamlined the process for deleting obsolete backups and improved overall readability.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 2086074
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6777f9dd96dc7b00081c4be7
😎 Deploy Preview https://deploy-preview-36677--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 3, 2025

📝 Walkthrough

Walkthrough

The pull request modifies the Home Assistant backup documentation in the source/_includes/common-tasks/backups.md file. The changes focus on clarifying backup procedures, emphasizing that all backups are encrypted, and refining the instructions for creating, restoring, and managing backups. The documentation now provides more precise guidance about backup processes, including references to the backup emergency kit and streamlining the explanation of backup-related tasks.

Changes

File Change Summary
source/_includes/common-tasks/backups.md - Rephrased section on encrypted backups
- Added reference to backup emergency kit documentation
- Removed statement about manual backup encryption
- Refined onboarding backup restoration instructions
- Streamlined backup deletion process explanation

Note: No changes were made to exported or public entity declarations in this pull request.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
source/_includes/common-tasks/backups.md (3)

Line range hint 68-80: Consider minor wording improvement

The instructions are clear and accurate, but there's a small opportunity to improve readability in the first sentence.

-This creates a backup instantly. You can create a manual backup at any time, irrespective of any automatic backups you may have defined.
+You can create a manual backup at any time, regardless of any automatic backups you may have defined. The backup is created instantly.

133-134: Fix grammatical error in migration description

There's a grammatical error in the sentence structure.

-During onboarding, to migrate your setup to a new device or a to device on which you performed a factory reset.
+During onboarding, to migrate your setup to a new device or to a device on which you performed a factory reset.
🧰 Tools
🪛 LanguageTool

[grammar] ~133-~133: A noun might be missing after either ‘a’ or ‘to’ (if ‘to’ is used as a preposition).
Context: ...o migrate your setup to a new device or a to device on which you performed a factory...

(A_TO)


Line range hint 178-197: Standardize credential terminology

For consistency with modern technical writing conventions, consider updating the credential terminology.

-The login password and user name must match
+The login password and username must match
-enter the password and user name as they were
+enter the password and username as they were
🧰 Tools
🪛 LanguageTool

[style] ~178-~178: It’s more common nowadays to write this noun as one word.
Context: ...the backup. - The login password and user name must match the ones you used at the tim...

(RECOMMENDED_COMPOUNDS)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2e3805 and 4a938c6.

📒 Files selected for processing (1)
  • source/_includes/common-tasks/backups.md (9 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_includes/common-tasks/backups.md

[grammar] ~133-~133: A noun might be missing after either ‘a’ or ‘to’ (if ‘to’ is used as a preposition).
Context: ...o migrate your setup to a new device or a to device on which you performed a factory...

(A_TO)


[style] ~178-~178: It’s more common nowadays to write this noun as one word.
Context: ...the backup. - The login password and user name must match the ones you used at the tim...

(RECOMMENDED_COMPOUNDS)


[style] ~197-~197: It’s more common nowadays to write this noun as one word.
Context: ...he login screen, enter the password and user name as they were at the time the backup was...

(RECOMMENDED_COMPOUNDS)

🔇 Additional comments (4)
source/_includes/common-tasks/backups.md (4)

47-48: Well-structured addition about backup encryption!

The added information clearly emphasizes that backups are encrypted and properly directs users to the emergency kit documentation.


56-57: Clear explanation of cloud backup storage limitations!

The section effectively communicates the storage limit, encryption requirement, and the need for the emergency kit.


110-112: Clear explanation of cloud backup availability!

The section effectively explains the cloud backup storage behavior and access requirements.


Line range hint 1-197: Overall documentation improvements are excellent!

The changes successfully achieve the PR's objective of clarifying that backups are always encrypted. The documentation is well-structured, comprehensive, and provides clear guidance for users. The additions about the backup emergency kit and encryption requirements are consistently emphasized throughout the document.

🧰 Tools
🪛 LanguageTool

[style] ~178-~178: It’s more common nowadays to write this noun as one word.
Context: ...the backup. - The login password and user name must match the ones you used at the tim...

(RECOMMENDED_COMPOUNDS)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
source/_includes/common-tasks/backups.md (2)

56-56: Consider adding emphasis on backup size limit.

The information about encryption and emergency kit is well-placed. Consider making the 5 GB limit more prominent, perhaps in a note or warning block, as it's a critical limitation users should be aware of.

-If you have Home Assistant Cloud, you can store a backup of maximum 5&nbsp;GB on Home Assistant Cloud.
+{% note %}
+**Important:** Home Assistant Cloud backup storage is limited to 5&nbsp;GB maximum.
+{% endnote %}

133-133: Fix grammatical error: missing article.

Add the missing article "a" in the sentence.

-During onboarding, to migrate your setup to a new device or to device on which you performed a factory reset.
+During onboarding, to migrate your setup to a new device or to a device on which you performed a factory reset.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~133-~133: Possible missing article found.
Context: ...igrate your setup to a new device or to device on which you performed a factory reset....

(AI_HYDRA_LEO_MISSING_A)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a938c6 and 2086074.

📒 Files selected for processing (1)
  • source/_includes/common-tasks/backups.md (9 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_includes/common-tasks/backups.md

[uncategorized] ~133-~133: Possible missing article found.
Context: ...igrate your setup to a new device or to device on which you performed a factory reset....

(AI_HYDRA_LEO_MISSING_A)

🔇 Additional comments (4)
source/_includes/common-tasks/backups.md (4)

47-47: LGTM! Clear emphasis on backup encryption.

The addition of encryption information and the emergency kit reference improves user awareness of security measures.


Line range hint 68-80: LGTM! Clear and well-structured manual backup instructions.

The instructions are logically ordered and maintain consistency with the encryption message. The addition of the emergency kit reference is well-placed.


110-112: LGTM! Clear prerequisites for cloud backup access.

The conditions for accessing cloud backups are clearly stated.


172-178: LGTM! Clear restoration instructions with encryption key requirement.

The instructions clearly explain the need for the encryption key from the backup emergency kit. The login credential requirements are well-explained.

@frenck frenck added this to the 2025.1 milestone Jan 3, 2025
@frenck frenck merged commit 5e0c64e into next Jan 3, 2025
9 checks passed
@frenck frenck deleted the backup-steps-encryption branch January 3, 2025 14:58
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Jan 3, 2025
frenck pushed a commit that referenced this pull request Jan 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants