Skip to content

Add note to iOS actionable notifications for clarity #3720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2017
Merged

Add note to iOS actionable notifications for clarity #3720

merged 3 commits into from
Nov 7, 2017

Conversation

dancwilliams
Copy link
Contributor

Description:

Added note to remind users to update push settings within the app. There are multiple community questions around this and performing this update will take care of many issues when implementing actionable notifications.

Added note to remind users to update push settings within the app.  There are multiple community questions around this and performing this update will take care of many issues when implementing actionable notifications.
@@ -141,3 +141,4 @@ Notes:

* `textInput` will only exist if `behavior` was set to `textInput`.
* `actionData` is a dictionary with parameters passed in the `action_data` dictionary of the `push` dictionary in the original notification.
* When adding or updating push categories be sure to update push settings within the Home Assistant iOS app. This can be found within the app at Setting (gear icon) > Notification Settings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should "Setting" be "Settings"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Correcting now.

Corrected `Setting` to `Settings`
Copy link
Contributor

@mnoorenberghe mnoorenberghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@emlove emlove added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 26, 2017
@fabaff fabaff added Enhancement and removed Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Nov 6, 2017
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 9cd72c0 into home-assistant:next Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants